fix(stacker): update tpowerdown and hold current delay for motor driver #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on bench setup. TPOWERDOWN matches the behavior I get when I manually edit the registers. A period of 180ms from the last step pulse to when the current starts to drop with IHOLDDELAY.
TPOWERDOWN seems to be 16ms (which is the period added by incrementing the register by one) longer than what I would expect from the datasheet. I would say this is fine for now, not worth spending the time trying to fix the offset error (this might even be the normal behavior of the driver) - but people should know it's there and we should figure out exactly what is going on there at some point. IHOLDDELAY is correct with 16ms per current step reductions. 
|
vegano1
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering the tpowerdown and ihold delay to minimize the time it needs to change motor current; this should reduce the wobble when we turn on the z-brake before disabling the motor.